From c2607a257a75f64743e1f299cf06cb253b3b6b32 Mon Sep 17 00:00:00 2001 From: hoba Date: Wed, 12 Feb 2025 13:38:46 +0800 Subject: [PATCH] refactor(GeodesicMesh): simplify HCF and face addition logic --- .../Editor/GeodesicMesh.cs | 22 ++++--------------- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/Assets/UltraCombos.Metamesh/Editor/GeodesicMesh.cs b/Assets/UltraCombos.Metamesh/Editor/GeodesicMesh.cs index abf404c..0a2e44e 100644 --- a/Assets/UltraCombos.Metamesh/Editor/GeodesicMesh.cs +++ b/Assets/UltraCombos.Metamesh/Editor/GeodesicMesh.cs @@ -76,15 +76,6 @@ namespace Metamesh private int HighestCommonFactor(int a, int b) { - while (b != 0) - { - var r = a % b; - a = b; - b = r; - } - - return a; - /* var r = a % b; if (r == 0) { @@ -92,7 +83,6 @@ namespace Metamesh } return HighestCommonFactor(b, r); - */ } @@ -693,8 +683,7 @@ namespace Metamesh } } - this.face.Add(new List - { primTri.vecToidx[temp[0]], primTri.vecToidx[temp[1]], primTri.vecToidx[temp[2]] }); + this.face.Add(Enumerable.Range(0, 3).Select(i => primTri.vecToidx[temp[i]]).ToList()); } } @@ -716,8 +705,7 @@ namespace Metamesh } } - this.face.Add(new List - { primTri.vecToidx[temp[0]], primTri.vecToidx[temp[1]], primTri.vecToidx[temp[2]] }); + this.face.Add(Enumerable.Range(0, 3).Select(i => primTri.vecToidx[temp[i]]).ToList()); } } @@ -739,8 +727,7 @@ namespace Metamesh } } - this.face.Add(new List - { primTri.vecToidx[temp[0]], primTri.vecToidx[temp[1]], primTri.vecToidx[temp[2]] }); + this.face.Add(Enumerable.Range(0, 3).Select(i => primTri.vecToidx[temp[i]]).ToList()); } } @@ -767,8 +754,7 @@ namespace Metamesh nearTo[12].Add(new List { i, close[i][0] }); } } - - //var near = Enumerable.Range(0, 12).ToList(); + var near = Enumerable.Range(0, 12).ToDictionary(i => i); var nearIndex = 12; for (var i = 0; i < 12; i++)